Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add warning header #8063

Merged
merged 15 commits into from
May 24, 2024
Merged

feat: add warning header #8063

merged 15 commits into from
May 24, 2024

Conversation

loks0n
Copy link
Contributor

@loks0n loks0n commented May 2, 2024 •
edited

  • Adds a new response header X-Appwrite-Warning

It can contain multiple warnings delimetered by ;, for example:

X-Appwrite-Warning: Invalid SDK format version requested ; Wrong content-type requested
  • Adds an error message when an SDK designed for a later version of Appwrite is used.

@loks0n loks0n changed the base branch from main to 1.5.x May 2, 2024 12:53
stnguyen90
stnguyen90 requested changes May 2, 2024
View reviewed changes
app/controllers/general.php Outdated Show resolved Hide resolved
@loks0n loks0n requested a review from stnguyen90 May 7, 2024 10:34
@loks0n loks0n changed the base branch from 1.5.x to main May 8, 2024 09:08
@loks0n
Revert "Merge branch 'main' of https://github.com/appwrite/appwrite i…
91ee67d 
…nto feat-add-version-header"

This reverts commit 824309e, reversing
changes made to 2d09a3a.
@loks0n loks0n changed the base branch from main to 1.5.x May 8, 2024 09:09
@loks0n loks0n changed the title feat: add version header feat: add warning header May 15, 2024
@christyjacob4 christyjacob4 merged commit a414b2b into 1.5.x May 24, 2024
23 checks passed
@christyjacob4 christyjacob4 deleted the feat-add-version-header branch May 24, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stnguyen90 stnguyen90 stnguyen90 approved these changes

@christyjacob4 christyjacob4 christyjacob4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@loks0n @stnguyen90 @christyjacob4